Prepare release artefacts

obophenotype / bio-attribute-ontology

source files for OBA (Ontology of Biological Attributes)

https://obophenotype.github.io/bio-attribute-ontology

Creative Commons Zero v1.0 Universal

27 stars 11 forks source link

Prepare release artefacts #307

Closed rays22 closed 6 months ago

rays22 commented 6 months ago

Remove unintended equivalencies

Errors to be fixed: 1. OBA:2045390 basophil ratio appears to be equivalent to OBA:2045392 basophil to leukocyte ratio 2. OBA:2045391 eosinophil ratio appears to be equivalent to OBA:2045393 eosinophil to leukocyte ratio
resolution for release: 1. keep these: - OBA:2045389 leukocyte ratio - OBA:2045390 basophil ratio - OBA:2045391 eosinophil ratio 2. remove these: - OBA:2045393 eosinophil to leukocyte ratio - OBA:2045392 basophil to leukocyte ratio
explanation: 1. basophil is a leukocyte 2. eosinophil is a leukocyte --> resulting in unintended equivalencies

ar-ibrahim commented 6 months ago

OBA:2045393 eosinophil to leukocyte ratio - OBA:2045392 basophil to leukocyte ratio

@rays22 Yes eosinophils and basophils are leukocytes but I think these ratios refer to total leukocyte count.

rays22 commented 6 months ago

OBA:2045393 eosinophil to leukocyte ratio - OBA:2045392 basophil to leukocyte ratio

@rays22 Yes eosinophils and basophils are leukocytes but I think these ratios refer to total leukocyte count.

The label suggests that, but the logical definitions do not express that unfortunately. The two classes cause a certain type of error (incoherence) in the ontology. For this reason, I have removed the two classes above, because they are unintended equivalent classes of other ones. The two classes could be reintroduced if we can come up with a pattern with an appropriate logical axiom.