search

obophenotype / biological-spatial-ontology

An ontology for respresenting spatial concepts, anatomical axes, gradients, regions, planes, sides, and surfaces
Other
13 stars 5 forks source link

Add root entity annotation #41

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

Related to https://github.com/OBOFoundry/OBOFoundry.github.io/issues/2149

matentzn commented 2 years ago

How did you determine that this is the proper root?

cthoyt commented 2 years ago
  1. I looked at the results for BSPO from my automated analysis https://cthoyt.com/cob-root-analysis/#bspo
  2. I found that the edit file actually had some rearrangement going on compared to the most recent release that created that picture, so while I was browsing in protege I realized that all BSPO terms had this as a common ancestor
matentzn commented 2 years ago

Niiiiiice analysis table man!!!

I will get this merged but need some feedback from @balhoff to be sure.

cthoyt commented 2 years ago

yeah agreed, I was pretty confused by this too so @balhoff you can feel free to change this PR however you'd like.

balhoff commented 2 years ago

I think that looks good, thanks!

cthoyt commented 2 years ago

@balhoff its also possible to annotate more than 1 root or we can go deeper and expose BSPO terms too, what do you think?

balhoff commented 2 years ago

I think 'anatomical entity' is tidy.