obophenotype / cell-ontology

An ontology of cell types
https://obophenotype.github.io/cell-ontology/
Creative Commons Attribution 4.0 International
144 stars 49 forks source link

upper-level slims - develop definition, SOP, technical architecture & implement test cases. #1798

Closed dosumis closed 1 year ago

dosumis commented 1 year ago

Problem:

Services that rely on CL annotation to provide indexing, grouping and summaries of annotated data need a set (or sets) of high level terms to which they can map their annotations in order to drive summaries/faceting. For visualization purposes, they typically want summaries to provide single inheritance classifications.

To solve these problems, I propose that we develop and maintain one or more upper-level slims that consumers of the ontology can use for mapping-up their annotations. This should be co-ordinated with an increase in the addition of disjointness axioms - as these can potentially be used, together with upper-level slims, to reliably generate single-inheritance visualisations. (Where disjointness axiom may be unsafe, we might consider some other form of flagging of potential disjoints with APs).

Description of approach:

  1. upper slims should follow a naming convention so that they can be distinguished from other uses of the subset tag. Suggest: {some_name}_upper_slim
  2. Each slim should be maintained in a ROBOT template & built using ODK - for ease of editing/update. @anitacaron to train editors to set these up as needed.
  3. Add disjointness axioms between classes in the slim that we are very confident do not overlap
  4. For each slim, we need to define a scope against which coverage will be tested. Scope = one or more classes or class expressions. e.g. immune slim may have scope 'hematopoietic cell', eye slim 'cell that overalps some eye'.
  5. For each slim we should aim for 80-90% coverage where this is defined as % of cells in scope that are subclasses of terms in slim, excluding superclasses of terms in slim. @ubyndr to provide infrastructure for calculating scope and reporting terms that fall outside of scope.

Test cases

related work

Note

amcujba commented 1 year ago

Hello, this is the link to the preliminary PBMC hierarchy, up for discussion and review: https://docs.google.com/spreadsheets/d/1K-Z_IWVVEdCA6xo6ca_9aHc3WvYSFTf4-R-xYbINpn4/edit#gid=621727165

anitacaron commented 1 year ago

Hi @amcujba, could you provide the ID of the terms, please?

dosumis commented 1 year ago

Work on PBMC hierarchy has moved to #1912 & #1909

aleixpuigb commented 1 year ago

@dosumis, can this ticket be closed? Although related, the PBMC hierarchy ticket does not affect the slims.