obophenotype / cell-ontology

An ontology of cell types
https://obophenotype.github.io/cell-ontology/
Creative Commons Attribution 4.0 International
139 stars 49 forks source link

Add definitions to terms for neurons that lack them #2342

Open dosumis opened 4 months ago

dosumis commented 4 months ago

We have 71 terms for types of neuron that lack a text definition (see table below). We should define them

Strategies for finding more info:

  1. Many of these are We need to be able to see xrefs coming back in from external ontologies (particularly FBbt). These now live externally. @gouttegd - what is the easiest way to query for them? Can we use UberGraph?
  2. Many are grouping terms with logical defs, we can potentially use these logical defs to auto-roll textual definitions. @gouttegd - I believe you have an updated version of the software that FBbt uses for this. How easy would that be to deploy here?
  3. Some may be used by GO. These can be easily queried for in UberGraph or CL-KB (Cypher).

@AvolaAmg - can you prioritise terms that are obviously applicable to mammalian brain?

c.curie c.label c.definition c.database_cross_reference
CL:0000544 slowly adapting mechanoreceptor cell null null
CL:0000200 touch receptor cell null null
CL:0000203 gravity sensitive cell null null
CL:0000006 neuronal receptor cell null null
CL:1000082 stretch receptor cell null null
CL:0000200 touch receptor cell null null
CL:0000204 acceleration receptive cell null null
CL:0000707 R7 photoreceptor cell null null
CL:0000287 eye photoreceptor cell null null
CL:0000705 R6 photoreceptor cell null null
CL:0000690 R2 photoreceptor cell null null
CL:0000694 R3 photoreceptor cell null null
CL:0000697 R4 photoreceptor cell null null
CL:0000702 R5 photoreceptor cell null null
CL:0000687 R1 photoreceptor cell null null
CL:0000709 R8 photoreceptor cell null null
CL:0010009 camera-type eye photoreceptor cell null null
CL:0000707 R7 photoreceptor cell null null
CL:0000705 R6 photoreceptor cell null null
CL:0000697 R4 photoreceptor cell null null
CL:0000690 R2 photoreceptor cell null null
CL:0000490 photopic photoreceptor cell null null
CL:0000702 R5 photoreceptor cell null null
CL:0000709 R8 photoreceptor cell null null
CL:0000694 R3 photoreceptor cell null null
CL:0000687 R1 photoreceptor cell null null
CL:0000489 scotopic photoreceptor cell null null
CL:0000203 gravity sensitive cell null null
CL:0000551 unimodal nocireceptor null null
CL:0000567 polymodal nocireceptor null null
CL:0000376 humidity receptor cell null null
CL:0000207 olfactory receptor cell null [FMA:67860,MESH:D018034,Wikipedia:Olfactory_receptor_neuron,BTO:0004185]
CL:0000251 extramedullary cell null null
CL:0000102 polymodal neuron null null
CL:0000691 stellate interneuron null null
CL:0010010 cerebellar stellate cell null null
CL:0000029 neural crest derived neuron null null
CL:0000028 CNS neuron (sensu Nematoda and Protostomia) null null
CL:1000245 posterior lateral line ganglion neuron null null
CL:0008021 anterior lateral line ganglion neuron null null
CL:0008028 visual system neuron null null
CL:1000222 stomach neuroendocrine cell null null
CL:0000253 eurydendroid cell null null
CL:0000532 CAP motoneuron null null
CL:0000112 columnar neuron null null
CL:1000606 kidney nerve cell null [KUPO:0001015]
CL:0000678 commissural neuron null null
CL:0000200 touch receptor cell null null
CL:0000117 CNS neuron (sensu Vertebrata) null null
CL:4023032 ON retinal ganglion cell null null
CL:0000555 neuronal brush cell null null
CL:0010010 cerebellar stellate cell null null
CL:4023057 cerebellar inhibitory GABAergic interneuron null null
CL:0000410 CNS long range interneuron null null
CL:0000406 CNS short range interneuron null null
CL:1000001 retrotrapezoid nucleus neuron null null
CL:4023039 amygdala excitatory neuron null null
CL:0010010 cerebellar stellate cell null null
CL:4023057 cerebellar inhibitory GABAergic interneuron null null
CL:0000379 sensory processing neuron null null
CL:0000532 CAP motoneuron null null
CL:0000691 stellate interneuron null null
CL:4023057 cerebellar inhibitory GABAergic interneuron null null
CL:0000410 CNS long range interneuron null null
CL:0000406 CNS short range interneuron null null
CL:4023057 cerebellar inhibitory GABAergic interneuron null null
CL:0000246 Mauthner neuron null null
CL:0000397 ganglion interneuron null null
CL:4023039 amygdala excitatory neuron null null
CL:0000109 adrenergic neuron null [MESH:D059331]
CL:4023057 cerebellar inhibitory GABAergic interneuron null null
gouttegd commented 4 months ago

We need to be able to see xrefs coming back in from external ontologies (particularly FBbt). These now live externally. @gouttegd - what is the easiest way to query for them? Can we use UberGraph?

Currently, only the FBbt mappings live externally (in a SSSOM mapping set). The mappings with the other species-specific ontologies are still present directly as cross-references in the -edit file.

As for the FBbt mappings, they are converted to cross-references and injected into CL at build time, so they do appear in all released products as “normal” cross-references and they can be queried by any tool that knows how to access/display cross-references – which should include Ubergraph.

Here, no FBbt xrefs are visible for any of the terms listed because none of them are actually mapped to any FBbt term.

Many are grouping terms with logical defs, we can potentially use these logical defs to auto-roll textual definitions. @gouttegd - I believe you have an updated version of the software that FBbt uses for this. How easy would that be to deploy here?

Very easy. Note however that the software will only generate text definitions for terms that have a so-called “dot definition” (a definition consisting of a single dot, .). It will not generate definitions for terms that have no definition annotation at all.

So we’ll need to either add a . definition to all those terms, or I will need update the software to add the possibility to work on definition-lacking terms (feasible, but will take a bit more time).

dosumis commented 4 months ago

Here, no FBbt xrefs are visible for any of the terms listed because none of them are actually mapped to any FBbt term.

All of the R photoreceptors in the table clearly should be. Can you add them to the mapping file?

dosumis commented 4 months ago

Looks like there are some unmapped fish terms too.

c.curie c.label c.definition c.database_cross_reference
CL:1000245 posterior lateral line ganglion neuron null null
CL:0008021 anterior lateral line ganglion neuron null null
CL:0000246 Mauthner neuron null null
gouttegd commented 4 months ago

All of the R photoreceptors in the table clearly should be.

In principle I am reluctant to map terms without a text definition to ensure the terms do refer to the same thing. In this particular case, I’ll admit the CL terms probably cannot refer to anything else, so OK.

gouttegd commented 4 months ago

Looks like there are some unmapped fish terms too.

For reasons unknown (at least to me), ZFA-CL mappings are represented as cross-references, but on the ZFA side (ZFA terms carry cross-references pointing to CL terms, not the other way round; some CL terms do have cross-references to ZFA but they are ignored while bridging the two ontologies together, the source of truth is ZFA).

This means that the ZFA-CL mappings cannot be seen from CL; they can be seen from ZFA only, or from the SSSOM mapping set that Uberon is deriving from the ZFA xrefs.

CL:0000246 is mapped to ZFA:0009149; the other two CL terms CL:1000245 and CL:0008021 are not mapped to anything in CL. That must be fixed on the ZFA side.

ybradford commented 4 months ago

@gouttegd what does ZFIN need to do for CL:1000245 and CL:0008021 in ZFA?

gouttegd commented 4 months ago

@ybradford Find the equivalent terms in ZFA and add CL cross-references to them.

But that is assuming that ZFA does have equivalent terms for CL:1000245 and CL:0008021, which may not actually be the case.

CL:1000245 is posterior lateral line ganglion neuron. From what I see, ZFA has a posterior lateral line ganglion (ZFA:0001314) (which is already mapped to its Uberon equivalent UBERON:2001314), but it does not have a term for a neuron of that ganglion.

Likewise for CL:0008021 (anterior lateral line ganglion neuron). ZFA has a anterior lateral line ganglion) (ZFA:0001391) (already mapped to its Uberon equivalent UBERON:2001391), but no term for a neuron of that ganglion.

So it may not be something for ZFA to fix after all.