obophenotype / cell-ontology

An ontology of cell types
https://obophenotype.github.io/cell-ontology/
Creative Commons Attribution 4.0 International
145 stars 49 forks source link

remove broad synonym DaN from "substantia nigra dopaminergic neuron" #2605

Closed dosumis closed 1 month ago

dosumis commented 1 month ago

Shouldn't 'DaN' be an exact synonym on Dopaminergic neuron?

substantia nigra dopaminergic neuron has_broad_synonym "DaN"

In general I would only use broad synonym if there is no term to attach the same name to as an exact synonym to (or maybe in this case 'related' + abbreviation - following general policy on abbreviations). Important to think from the perspective of someone searching the ontology.

(Apologies for missing this on PR. Easier to read if you run gogoedit diff when you want a review.)

AvolaAmg commented 1 month ago

No worries at all I will get rid of it right now. Good to know for the future!

AvolaAmg commented 1 month ago

all done @dosumis you can see it in the new commit.