search

obophenotype / developmental-stage-ontologies

Source files for various species-specific stage ontologies
10 stars 5 forks source link

Make clean target is mildly problematic #46

Closed cmungall closed 4 years ago

cmungall commented 7 years ago

https://github.com/obophenotype/developmental-stage-ontologies/blob/97fa5b7e176f8c7f72cd5c7115d2fc36f35e8bb3/src/Makefile#L16-L17

clean: 
    $(foreach o, $(ONT_PREFIXES), @rm -f $o/$o.owl $o/$o$(BRIDGE_UBERON_SUFFIX) $o/$o$(COMPOSITE_UBERON_SUFFIX))

this expands to 

rm -f acardv/acardv.owl acardv/acardv-bridge-to-uberon.obo acardv/acardv-uberon.obo  @rm -f btaudv/btaudv.owl ... @rm -f ...

this technically works, but it is a bit odd as it attempts to delete two extra files @rm and -f. These don't exist so nothing bad happens, but in the interests of cleanliness, perhaps instead:

DERIVED =  $(foreach o, $(ONT_PREFIXES), $o/$o.owl $o/$o$(BRIDGE_UBERON_SUFFIX) $o/$o$(COMPOSITE_UBERON_SUFFIX))

clean: 
    @rm -f $(DERIVED)