obophenotype / human-phenotype-ontology

Ontology for the description of human clinical features
http://obophenotype.github.io/human-phenotype-ontology/
Other
285 stars 51 forks source link

long tubular bones vs short tubular bones #1374

Closed azankl closed 7 years ago

azankl commented 7 years ago

Tubular bones can be further subdivided into short tubular bones (e.g. phalanges) and long tubular bones (e.g. femurs). HP:0003026 (short long bones) has the synonyms short tubular bones and shortened long tubular bones. Shortened long tubular bones suggests that only the long tubular bones (e.g. femurs) are shortened, while short tubular bones and short long bones implies both the long tubular bones and the short tubular bones are shortened. Since HPO generally does not seem to differentiate between short tubular bones and long tubular bones, I would suggest removing the synonym 'shortened long tubular bones' to remove this inconsistency. Alternatively, we could consider introducing terms for shortened short tubular bones and shortened long tubular bones, but I feel that is overkill and not really needed.

cmungall commented 7 years ago

AFAICT phalanges and femurs are traditionally classified as long bones. This is what many classic sources say, as well as ontologies like the FMA.

I'm not sure what the benefit would be in further subdividing these, seems non-standard?

So I agree 'shortened long tubular bones' is not really consistent, but perhaps it's OK to retain as a synonym and mark as non-standard?

On 5 Feb 2017, at 20:01, Andreas Zankl wrote:

Tubular bones can be further subdivided into short tubular bones (e.g. phalanges) and long tubular bones (e.g. femurs). HP:0003026 (short long bones) has the synonyms short tubular bones and shortened long tubular bones. Shortened long tubular bones suggests that only the long tubular bones (e.g. femurs) are shortened, while short tubular bones and short long bones implies both the long tubular bones and the short tubular bones are shortened. Since HPO generally does not seem to differentiate between short tubular bones and long tubular bones, I would suggest removing the synonym 'shortened long tubular bones' to remove this inconsistency. Alternatively, we could consider introducing terms from shortened short tubular bones and shortened long tubular bones, but I feel that is overkill and not really needed.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/obophenotype/human-phenotype-ontology/issues/1374

azankl commented 7 years ago

agree further subdividing the long bones is not useful, thats why I thought the synonym 'shortened long tubular bones' was confusing, as it suggests we are distinguishing between short and long tubular bones and only the long tubular bones are included here. We could add 'shortened short tubular bones' as a synonym to make clear that both short and long tubular bones that are shortened are lumped under this term.