obophenotype / human-phenotype-ontology

Ontology for the description of human clinical features
http://obophenotype.github.io/human-phenotype-ontology/
Other
293 stars 51 forks source link

Loinc 883-9: "ABO group [Type] in Blood" #3422

Closed kingmanzhang closed 5 years ago

kingmanzhang commented 6 years ago

Suggest creating a new term for Loinc: 883-9 [ABO group [Type] in Blood] New term label: ABO blood type New term comment (if any): (TEST) Some loinc tests are not for "abnormal" phenotypes. Does HPO consider such terms? Your biocurator ID for loinc2hpo (if desired): null

pnrobinson commented 6 years ago

@cmungall @mellybelly @drseb Should we introduce a branch of HPO to capture some medically important non-abnormal phenotypes such as blood group?

drseb commented 6 years ago

Searching bioportal for blood group makes me think this is a good idea. But maybe @cmungall @mellybelly know more

pnrobinson commented 5 years ago

@drseb @cmungall @mellybelly -- OK so I will introduce a new subontology for blood group. This will be useful for the common disease project and would mean we could provide this information with Exomiser etc. Shout if anybody disagrees!

drseb commented 5 years ago

go for it

pnrobinson commented 5 years ago

@kingmanzhang can we discuss how LOINC represents this? I think that the proper phenotype is presence of an antigen (anti-A, anti-B). It will be difficult to represent the blood group O in this fashion though, and so for the ABO system maybe we also want to record the inference of A, B, AB, and O. For all of the other systems, I think it is the presence of antigen that is recorded.

kingmanzhang commented 5 years ago

Sure. Yes, AB and O are tricky. The current annotation format does not allow logical operations. So for AB, we have to create a term like presence of BOTH anti-A and anti-B; for O, it needs negation of Presence of anti-A AND negation of Presence of anti-B. This becomes pretty complicated. Maybe an easier solution is just creating individual terms for each?

cmungall commented 5 years ago

Yes, precompose and provide OWL definitons

On Thu, Jan 24, 2019 at 5:48 AM Xingmin Aaron Zhang < notifications@github.com> wrote:

Sure. Yes, AB and O are tricky. The current annotation format does not allow logical operations. So for AB, we have to create a term like presence of BOTH anti-A and anti-B; for O, it needs negation of Presence of anti-A AND negation of Presence of anti-B. This becomes pretty complicated. Maybe an easier solution is just create individual terms for each?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/obophenotype/human-phenotype-ontology/issues/3422#issuecomment-457202382, or mute the thread https://github.com/notifications/unsubscribe-auth/AADGObM2X5L69VP9NOYUy0Tz5PSr2c03ks5vGbmtgaJpZM4SY9e6 .

pnrobinson commented 5 years ago

No this is not the problem. If the LOINC tests are not complete, i.e., if a test was made for A but for whatever reason no test was made for B, then we cannot determine the blood type. We should never ever try to infer the blood group based on "atomic" LOINC tests, because if any mistake is made with a transfusion it can be lethal. We do not want to go anywhere near there. AFAIK all of the other many blood groups are simpler in this respect

kingmanzhang commented 5 years ago

I agree with your point. That does make a lot of sense if there are separate LOINC tests for anti-A and anti-B. But I do not think LOINC reports such granular findings:

https://r.details.loinc.org/LOINC/883-9.html?sections=Comprehensive

It appears that internally the antigens findings are selected but then an outcome is inferred (Type A, Type B, Type AB or Type O) and reported.

pnrobinson commented 5 years ago

created terms under HP_0032224 @kingmanzhang

callahantiff commented 5 years ago

Sorry, I know this is closed as well. While LOINC does not report separate blood types, there are several SNOMED CT diagnosis terms related to different blood types. Would you consider discussing this further? Happy to open a new issue if you prefer.

pnrobinson commented 5 years ago

@callahantiff Let's make this a new issue. We are planning on adding more blood type terms that should then be conneced to LOINC terms...

callahantiff commented 5 years ago

OK, great! I will make an issue and start by compiling examples from the data I have.