obophenotype / human-phenotype-ontology

Ontology for the description of human clinical features
http://obophenotype.github.io/human-phenotype-ontology/
Other
286 stars 51 forks source link

subclasses of Abnormal liver morphology #4668

Closed cmungall closed 5 years ago

cmungall commented 5 years ago

HPO term

HP:0410042 Abnormal liver morphology

Suggested revision and reasons

Current def is "Any structural anomaly of the bile-secreting organ ", which maybe encompasses more than is meant by morphology in other domains?

these are some of the subclasses:

These aren't subclasses in the pato sense of morphological. It may be that this is the hierarchy clinicians expect but in this case we should include some kind of internal curator note and use a different pato class in the definition, which is currently

Equivalent to: 
has part some (
    morphology and 
    inheres in some liver and 
    has modifier some abnormal)
pnrobinson commented 5 years ago

@cmungall for me all three of these terms are clearly morphology -- the divide is basically between items that can be in principle observed in a snapshot and those for which a time course is necessary.

As for PATO, ectopic is definitely morphology for the organism with ectopic X, and I guess it is a modeling decision whether ectopic is also morphology for X, but I would suggest that this would be the most consistent way of doing things.

I do not understand your distinction between structural and morphological -- I thought that these words are nearly synonymous, e.g. Wikipedia: Morphology is a branch of biology dealing with the study of the form and structure of organisms and their specific structural features.

cmungall commented 5 years ago

I like your distinction, it is very clear and easy to apply.

I had thought morphology was used in a more restrictive sense in some ontologies but I may be wrong.

It seems that PATO needs some work here as it's conception of morphology is much more restricted than how it is used in HP and MP. E.g. PATO does not include color or ectopic under morphology, in contrast to how it is used in HP, MP, TO and others. cc @matentzn @dosumis

pnrobinson commented 5 years ago

@cmungall Should we move this discussion to the PATO tracker? I have had a look at the hierarchy near here and think it is OK.

cmungall commented 5 years ago

yep - can you organize the pato morphology tickets @nicolevasilevsky ?

nicolevasilevsky commented 5 years ago

Yes, will do!

nicolevasilevsky commented 5 years ago

I created a ticket in the PATO tracker, I will close this here