search

obophenotype / ncbitaxon

Build for NCBITaxon
BSD 3-Clause "New" or "Revised" License
27 stars 7 forks source link

Remove extra # symbol from IRIs of some taxonomic rank terms? #96

Open allenbaron opened 10 months ago

allenbaron commented 10 months ago

Three taxonomic rank terms appear to have an extra # in their IRIs:

  1. http://purl.obolibrary.org/obo/NCBITaxon#_species_group
  2. http://purl.obolibrary.org/obo/NCBITaxon#_species_subgroup
  3. http://purl.obolibrary.org/obo/NCBITaxon#_taxonomic_rank

All other taxonomic rank IRIs use the prefix http://purl.obolibrary.org/obo/NCBITaxon_.

Should the extra # be removed from these IRIs?

Noting that none of the taxonomic rank terms have IRIs that resolve.

balhoff commented 10 months ago

Should NCBITaxon use identifiers from the OBO TAXRANK ontology?

cmungall commented 10 months ago

taxrank is probably a bigger decision, but I think it makes sense. Made a distinct issue #97

The odd URI issue is an unfortunate but known consequence of

It was probably a mistake for us to place the subsets directly in the NCBITaxon namespace, we don't own this. Should have been done the same way as go/uberon/doid/etc, which is suboptimal but predictable.

The decision is

  1. leave as is for now and make a bigger change to taxrank (#97) later
  2. change the namespace for the subset to be obo:ncbitaxon# (fixing the weirdness issue)