Remove extra # symbol from IRIs of some taxonomic rank terms?

obophenotype / ncbitaxon

Build for NCBITaxon

BSD 3-Clause "New" or "Revised" License

25 stars 7 forks source link

Remove extra # symbol from IRIs of some taxonomic rank terms? #96

Open allenbaron opened 8 months ago

allenbaron commented 8 months ago

Three taxonomic rank terms appear to have an extra # in their IRIs:

All other taxonomic rank IRIs use the prefix http://purl.obolibrary.org/obo/NCBITaxon_.

Should the extra # be removed from these IRIs?

Noting that none of the taxonomic rank terms have IRIs that resolve.

balhoff commented 8 months ago

Should NCBITaxon use identifiers from the OBO TAXRANK ontology?

cmungall commented 8 months ago

taxrank is probably a bigger decision, but I think it makes sense. Made a distinct issue #97

The odd URI issue is an unfortunate but known consequence of

how we decided to model the URIs for the subsets
how these are translated into obo format

It was probably a mistake for us to place the subsets directly in the NCBITaxon namespace, we don't own this. Should have been done the same way as go/uberon/doid/etc, which is suboptimal but predictable.

The decision is

leave as is for now and make a bigger change to taxrank (#97) later
change the namespace for the subset to be obo:ncbitaxon# (fixing the weirdness issue)