obophenotype / provisional_cell_ontology

Draft cell type definitions from data - candidates for inclusion in CL
Creative Commons Attribution 4.0 International
11 stars 1 forks source link

Imports bringing in errors #20

Closed shawntanzk closed 2 years ago

shawntanzk commented 2 years ago

Errors aside from duplicate labels that will be fixed once we add species prefix include a bunch of duplicate def and multiple def from imports

For multiple defs - I would have thought that with base file imports now this would be solved @matentzn? PCL does have latest ODK. Do I need to redirect imports to use basefile somewhere for that to work?

There are duplicate_definition errors - this is from UBERON . issues - this is fixed here (https://github.com/obophenotype/uberon/issues/2129) and I think just needs new UBERON release then import

shawntanzk commented 2 years ago

Related to #16

shawntanzk commented 2 years ago

Of note, there is a whole bunch of duplicate_exact_synonym warning - these are generated by having same names from different species, and individuals and class, as the same thing - good example is with VLCM - not sure if this will affect search and all @dosumis - thought I'd imagine it wouldn't be overly bad a thing: <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

CL:4023051 | oboInOwl:hasExactSynonym | VLMC -- | -- | -- obo:PCL_0011622 | oboInOwl:hasExactSynonym | VLMC obo:PCL_0012126 | oboInOwl:hasExactSynonym | VLMC obo:PCL_0012526 | oboInOwl:hasExactSynonym | VLMC obo:PCL_0013134 | oboInOwl:hasExactSynonym | VLMC obo:PCL_0013509 | oboInOwl:hasExactSynonym | VLMC obo:PCL_0013534 | oboInOwl:hasExactSynonym | VLMC

shawntanzk commented 2 years ago

Fixed what we need to locally