obophenotype / uberon

An ontology of gross anatomy covering metazoa. Works in concert with https://github.com/obophenotype/cell-ontology
http://obophenotype.github.io/uberon/
Other
128 stars 28 forks source link

new term request "copepod prosome" #1395

Open diatomsRcool opened 6 years ago

diatomsRcool commented 6 years ago

Please add as a child to "tagma" http://purl.obolibrary.org/obo/UBERON_6000002 "copepod prosome" The forward section of the copepod body containing the head. It is separated form the rear section of the body (urosome) by a single point of articulation.

diatomsRcool commented 6 years ago

https://en.wikipedia.org/wiki/Tagma_(biology) for reference

cmungall commented 6 years ago

cc @dosumis

@diatomsRcool - do you want access to the insect module? You should be able to go ahead and make pull requests here https://github.com/obophenotype/insect-anatomy-ontology

cmungall commented 6 years ago

doh copepods aren't insects... but nevertheless the insect module has a lot of stuff useful for arthropods, thoughts @dosumis ?

diatomsRcool commented 6 years ago

yeah, i guess it just depends if non-insect parts are welcome in the insect anatomy ontology @dosumis ?

dosumis commented 6 years ago

We sold probably add some high level arthropod terms to Uberon. For this term we could add tagma to Uberon as a super class for prosome.

On Jan 11, 2018 5:00 PM, "diatomsRcool" notifications@github.com wrote:

yeah, i guess it just depends if non-insect parts are welcome in the insect anatomy ontology @dosumis https://github.com/dosumis ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/obophenotype/uberon/issues/1395#issuecomment-357075074, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4xwmiiH3ddHIdLWgsbqVlERmyGhkPks5tJoRugaJpZM4RbYnx .

diatomsRcool commented 6 years ago

tagma is in Uberon, I think

diatomsRcool commented 6 years ago

So where did we land with this? Am I clear to add to the insect module?

dosumis commented 6 years ago

Sorry to be slow on this.

As everything in the insect anatomy has an Uberon ID I guess the only issues are:

cmungall commented 6 years ago

who would think to look

Note that the insect module actually gets incorporated into uberon in the main release. So from a user perspective everything is equally easy (or hard) to find. the module split is really about making it easier for a community to edit part of the ontology.

ID ranges are currently 6nnnnnn (see https://github.com/obophenotype/insect-anatomy-ontology/issues/7)

My preference here is simply to rename https://github.com/obophenotype/insect-anatomy-ontology to https://github.com/obophenotype/arthropod-anatomy-ontology, and to allow classes like UBERON:6000002 ! tagma to be used for arthropods.

dosumis commented 6 years ago

My preference here is simply to rename https://github.com/obophenotype/insect-anatomy-ontology to https://github.com/obophenotype/arthropod-anatomy-ontology, and to allow classes like UBERON:6000002 ! tagma to be used for arthropods.

OK. Happy with that if you are. Tagma definition should be updated as its currently very insect specific.

Dug this proposed tagma def out from old work on AAO that never saw the light of day (would be great to find time/resources/people to revisit this work):

def: "A subdivision of the organism along the anterior-posterior axis that consists of multiple adjacent segments that are either fused, and/or share more structure with each other than with segments in adjacent tagmata."

@diatomsRcool are you happy/able to do the edits?

diatomsRcool commented 6 years ago

Sure.

diatomsRcool commented 6 years ago

Just so I don't screw this up...... I'm 1. changing the name of "insect-anatomy-ontology" to "arthropod-anatomy-ontology", 2. editing the definition of tagma in uberon, 3. adding copepod prosome to arthropod-anatomy-ontology. Correct?

dosumis commented 6 years ago

I'm 1. changing the name of "insect-anatomy-ontology" to "arthropod-anatomy-ontology", 2. editing the definition of tagma in uberon, 3. adding copepod prosome to arthropod-anatomy-ontology.

Correct?

Yep. But looks like tagma (UBERON:6000002) is currently in the 'insect-anatomy-ontology' file (everything there has an Uberon ID). Also make sure to set ID range appropriately.

diatomsRcool commented 6 years ago

I can't seem to get my edited obo file to save. Should I not be doing this in Protege?

cmungall commented 6 years ago

You can edit obo in protege. We like to keep source in obo for diff purposes.

In the absence of editor manual for the insect/arthro module, the GO docs should be a good proxy: http://go-ontology.readthedocs.io/en/latest/

diatomsRcool commented 6 years ago

I think this might be what's happening https://github.com/protegeproject/protege/issues/501

cmungall commented 6 years ago

does it look like this?

image

cmungall commented 6 years ago

I know what this is.. hold on..

diatomsRcool commented 6 years ago

Yes, it looks like this

screen shot 2018-01-22 at 4 30 52 pm
diatomsRcool commented 5 years ago

Where are we with this?

cmungall commented 5 years ago

Do you get this with latest Protege beta?

diatomsRcool commented 5 years ago

I'm using 5.2.0 Is that still beta?