obophenotype / uberon

An ontology of gross anatomy covering metazoa. Works in concert with https://github.com/obophenotype/cell-ontology
http://obophenotype.github.io/uberon/
Other
131 stars 29 forks source link

CALOHA - UBERON mapping problems #224

Closed lydiecalipho closed 3 years ago

lydiecalipho commented 11 years ago

Among the mappings to CALOHA that you are providing, could you please check the three following ones :

1) late embryo UBERON:0000323 fetus TS-0360 -> there is no def for the UBERON term so we do not know if both terms are equivalent

2) Egg UBERON:0007379 Ovum TS-2191 This is not correct according to UBERON definition for Egg: The hard-shelled reproductive body produced by a bird and especially by the common domestic chicken; also: its contents used as food.

3) synovial membrane of synovial joint UBERON:0002018 Synovium TS-0998 It seems that layer of synovial tissue UBERON:0007616 would be more appropriate

Thanks!

Lydie and Paula (CALIPHO)

cmungall commented 11 years ago

There is some discussion of fetus vs late embryo here: https://docs.google.com/document/d/11y-8bFnsGaT8phrAvSl9szR_LXAANm43N-0Faq5sjrI/edit#heading=h.tj7d3b26x957

A multi-species definition is hard but we could include a statement that in humans this is synonymous with fetus (week 9 pf?)

lydiecalipho commented 11 years ago

Thanks for the comment. The problem here is exactly the one that was discussed in your document! You consider that a fetus ("late embryo") IS an embryo , and we do not. According to our definition for fetus : "The unborn young of a viviparous mammal, in the postembryonic period, after the major structures have been outlined."

I suggest that we do not map both terms for now, since it may be confusing for users.

we will review all the embryo/fetal part of CALOHA and come back to you later.

cmungall commented 11 years ago

I noticed in Caloha there are 38 or so "Fetal X" terms, and 20 or so "embryonic X" terms. In general we prefer to create subclasses where there is some biological characteristic that differentiates the class from a parent class, and suggest that annotations incorporate stage separately (allowing more precise specification, in terms of Carnegie Stages, or weeks pf, etc). But if these are useful for annotation we can add them, but we do have to be careful we mean the same thing by fetus.

On Mar 27, 2013, at 3:47 AM, lydiecalipho wrote:

Thanks for the comment. The problem here is exactly the one that was discussed in your document! You consider that a fetus ("late embryo") IS an embryo , and we do not. According to our definition for fetus : "The unborn young of a viviparous mammal, in the postembryonic period, after the major structures have been outlined."

I suggest that we do not map both terms for now, since it may be confusing for users.

we will review all the embryo/fetal part of CALOHA and come back to you later.

— Reply to this email directly or view it on GitHub.

paulacalipho commented 11 years ago

Hello,

We have been revising our gestational structure part of the ontology that includes embryonic and fetal tissues, organs and structures with the aim to map to UBERON.

Because of the usage we would like to give to our ontology in neXtProt, we try to give functional definitions to the terms in Caloha. That is why we map, for example, data obtained from a fetal kidney (or from a kidney from an embryo) to the term “fetal kidney” (or “embryonic kidney”). Mapping the data to “kidney” at developmental stage “fetal stage” (or “embryonic stage”) brings us the problem on how we define “kidney”, because it is defined with the function that the kidney has in adults.

To manage this discrepancy we envisaged two possible solutions: 1- First option (the one we took)

[Term] id: TS-0510 name: Kidney def: "Body organ that filters blood for the secretion of urine and that regulates ion concentrations." [MeSH:Kidney] synonym: "Renal" RELATED [] xref: BTO:0000671 xref: EV:0100096 xref: FMA:7203 xref: MESH:D007668 xref: UBERON:0002113 xref: URL:http://www.proteinatlas.org/dictionary/normal/kidney relationship: part_of TS-1323 ! Urinary system

[Term] id: TS-0342 name: Fetal kidney def: "Fetal structure that gives rise to adult kidney." [NPX:PDR] relationship: part_of TS-0360 ! Fetus

In the future we are planning to complete the ontology with the relationship “develop_from” to be able to connect both terms (useful for users searching for example data in kidney adult and not in fetal kidney, for example).

2- Second option (rejected) Define each term with the adult function and a description of fetal (and embryonic) development and function. This brings us the problem of mapping to other ontologies and more philosophical issues also.

We know that this is an issue of discussion in different ontologies (one can even argue that some organs continue to develop after birth!). This is - at least for the moment- the solution we found. So we propose you not to create those terms in UBERON (we make a step back) and see how the ontology evolves. In that way each ontology (UBERON and Caloha) maintain the internal coherence.

Here I give you some examples that show that some organs are not fully developed and functional at fetal stage, or have a different function in fetus.

Many thanks Paula from Calipho group

gouttegd commented 3 years ago

WARNING: This issue has been automatically closed because it has not been updated in more than 3 years. Please re-open it if you still need this to be addressed addressed addressed – we are now getting some resources to deal with such issues.