Open cmungall opened 1 year ago
Another comment on the trivially true reciprocals - these are arguably shadow hierarchies and come with all the usual ragged lattice issues. I'm not sure I see a way of avoiding precoordinating in either hierarchy through.
However, we could do GCI inference in existing patterns - e.g. a simple-tissue-by-location DP would have a GCI to infer has-part to the most specific cell type
Following the discussion from the Uberon editors call on the 17th of July, I will create a DOSDP X_has_part_cell_type and document cases where we have used it previously.
This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.
We should have a DP to document has-part to CL. This would primarily be a documentative DP as it would not have an equivalence axiom.
We would document anti-patterns. The primary antipattern is making a has-part between a broad structure and a specific cell type. These are likely to lead to taxonomic incoherencies. E.g. "digestive tract subClassOf has-part some goblet cell" which would be false as DT encompasses almost all metazoa.
There are two sub-patterns:
You can see examples of both here:
2960
I don't know if we want to combine the sub-patterns in one yaml or have two (if we move to linkml for DPs then we would group them).
There are some nuanced OWL/logic issues when making these kinds of assertions. I think the first is notable but likely not a major issue.
The other thing we should bear in mind when making these is the principle of "reasonable completeness". See open world considered harmful. It could be confusing for users if they are led to believe they can "slice open" e.g. an alveolus and see all the cell types necessarily present, but when slicing open other structures they are curiously empty (by slice open here I mean a query
<structure> has-part some ?x
which can be done in ubergraph or with OAK). For these kinds of queries to be complete we would likely need to combine taxonomic variability GCIs with the has-part pattern