obophenotype / uberon

An ontology of gross anatomy covering metazoa. Works in concert with https://github.com/obophenotype/cell-ontology
http://obophenotype.github.io/uberon/
Other
131 stars 29 forks source link

Addition of OBO shorthands to the RO mirror: to preserve? #3016

Open gouttegd opened 1 year ago

gouttegd commented 1 year ago

When mirroring RO (prior to merging it into the merged_import.owl module), we currently give it some special treatment:

# Probably no reason to merge them first
# --add-obo-shorthand-to-properties: remove this to add mappings into remove
mirror/ro.owl: mirror/bspo.owl mirror-ro | $(MIRRORDIR)
    if [ $(MIR) = true ] && [ $(IMP) = true ]; then $(OWLTOOLS_NO_CAT) $(URIBASE)/ro.owl $< --merge-support-ontologies --merge-imports-closure --add-obo-shorthand-to-properties -o $@ && touch $@; fi

The above rule does two things:

Is the addition of “OBO shorthands” something we want/need to preserve here? If so, at some point we’ll need to figure out a way to do that without Owltools’ --add-obo-shorthands-to-properties, since ultimately we want to phase out our reliance on Owltools.

Related: #3014 (where we also make use of Owltools’ --add-obo-shorthands-to-properties)

gouttegd commented 6 months ago

I am strongly inclined to remove the special treatment of the OBO mirror (no more addition of OBO shorthands, no more use of Owltools) and treat it like all other mirrors, with the standard ODK-generated rules.

github-actions[bot] commented 1 day ago

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.