obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

add EFO traits/phenotypes #151

Open nlwashington opened 9 years ago

nlwashington commented 9 years ago

we need to be able to use the EFO traits/phenotypes.

for example coming from measurements: http://www.ebi.ac.uk/efo/EFO_0004611 or 'abnormality of the cardiovascular system': http://www.ebi.ac.uk/efo/EFO_0003966

drseb commented 9 years ago

looking at abnormality of the cardiovascular system, I find in the obo-version of EFO this entry.

[Term]
id: HP:0001626
name: abnormality of the cardiovascular system
def: "Any abnormality of the `cardiovascular system` (FMA:7161)." []
synonym: "abnormal phenotype of the cardiovascular system" EXACT []
synonym: "Cardiovascular Abnormalities" EXACT []
property_value: http://www.ebi.ac.uk/efo/MSH_definition_citation MSH:D018376 xsd:string
is_a: EFO:0000651 ! phenotype

So are you missing only the link between the HP-classes used in EFO and EFO-phenotype (EFO:0000651) or more?

cmungall commented 9 years ago

http://www.ebi.ac.uk/efo/EFO_0003966 appears to be eye disease, not abnormality of the cardiovascular system

So I think the request is to make sure the measurement hierarchy lines up, e.g. http://www.ebi.ac.uk/efo/EFO_0004611

drseb commented 8 years ago

I don't really understand this ticket. @cmungall can you comment?

cmungall commented 8 years ago

I think it's just adding equivalence axioms

drseb commented 8 years ago

adding EQs to what? HP?

cmungall commented 8 years ago

Not necessarily EQ pattern, but these would be in a bridge ontology and define EFOs

drseb commented 8 years ago

I see. I think I'll assign you, but let me know if I can/should do something concrete