obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

HP_0002539 Cortical dysplasia and HP_0006930 Frontoparietal cortical dysplasia are inferred to be equivalent #200

Open nicolevasilevsky opened 8 years ago

nicolevasilevsky commented 8 years ago

HP_0002539 Cortical dysplasia and HP_0006930 Frontoparietal cortical dysplasia are inferred to be equivalent

HP_0002539 Cortical dysplasia 'has part' some (dysplastic and ('inheres in' some 'cerebral cortex') and ('has modifier' some abnormal))

text def The presence of developmental dysplasia of the cerebral cortex.

HP_0006930 Frontoparietal cortical dysplasia 'has part' some (dysplastic and (('inheres in' some 'cerebral cortex') or ('inheres in' some 'parietal cortex')) and ('has modifier' some abnormal))

text def The presence of developmental dysplasia of the cortex of frontal lobe and the cortex of parietal lobe.

Suggested solution: Change the 'or' in the logical def for Frontoparietal cortical dysplasia to an 'and'?

Related to #149

@cmungall @pnrobinson

nicolevasilevsky commented 7 years ago

@drseb @pnrobinson These logical defs are different but the reasoner seems to be ignoring the or ('inheres in' some 'parietal cortex'))

Is the logical definition written incorrectly?

cmungall commented 7 years ago

These logical defs are different but the reasoner seems to be ignoring the or ('inheres in' some 'parietal cortex'))

Partly correct, UnionOf is outside EL++. However, reasoning is monotonic, so if a reasoner infers A=B, you can never dissuade it from this inference by adding new axioms. If an inference is puzzling try and paste the explanation (if this doesn't work post a Protege bug report)

cmungall commented 7 years ago

Be very careful with your ORs and ANDs.

Refer to: https://github.com/obophenotype/human-phenotype-ontology/issues/1030

This is analogous.