Open matentzn opened 5 years ago
I was thinking about this:
'has part' some
(
('star shaped' and ('inheres in' some 'lesion') )
and ('inheres in' some 'tail' )
and ('has modifier' some abnormal)
)
Double 'inheres in' is not allowed, maybe substitute 'occurs in' for the second one? Based on the BFO definition I think this is correct if 'lesion' is a process term as in the MP example. Where is 'lesion' coming from?
@sbello So far the best 'lesion' I have found is http://purl.obolibrary.org/obo/NCIT_C3824. Not sure if this works with the need for it to be a process term.
Thank you for helping to work through this with me.
Nope, reading the NCIT definition the lesion sounds like a material entity not a process. So, we're back to entity located on/in another entity. Closest pattern I can find is molecular entity in a location. This has the pattern '('inheres_in' some (%s and ('part_of' some %s)))' I think that should work here. So we would end up with
'has part' some
(
('star shaped' and ('inheres in' some (lesion and ('part of' some tail)) )
and ('has modifier' some abnormal)
)
Link to reference pattern https://github.com/obophenotype/upheno/blob/master/src/patterns/decreasedLevelOfMolecularEntityInLocation.yaml
Is there anything wrong with modelling lesions as material entities (I think this is much more accurate than process)?
No problem with modeling lesions as material entities. I also thinks this makes more sense than the current MP pattern which strikes me as too broad. The issue was occurs in BFO specifies process to entity so we can't use that relationship. The last pattern above is appropriate for entity to entity.
Probably better interpreted as a material entity rather than a process. This fits with the quality - a process can’t be ‘star shaped’.
You should therefore use:
star-shaped and inheres_in some (leision that part_of some tail)
Or perhaps
star-shaped and inheres_in some (leision that located_in some tail)
as we typically use part_of to record canonical anatomy.
I think OK to use NCIT term for now.
On 13 Dec 2018, at 18:29, Sofia Robb <notifications@github.com mailto:notifications@github.com> wrote:
@sbello https://github.com/sbello So far the best 'lesion' I have found is http://purl.obolibrary.org/obo/NCIT_C3824 http://purl.obolibrary.org/obo/NCIT_C3824. Not sure if this works with the need for it to be a process term.
Thank you for helping to work through this with me.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/obophenotype/upheno/issues/302#issuecomment-447071743, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4xy69_MtmaRnR67UzK1aClNwcfO_Hks5u4pyagaJpZM4ZRcnO.
This looks good. I will try out this out:
'has_part' some (%s and ('inheres_in' some (%s and ('part_of' some %s))) and ('qualifier' some 'abnormal'))
Thank you!
If the lesions are lesions and do not need to be further classified (i.e. different subtypes of lesions), I suggest to specify the pattern a bit (fix the lesion):
'has_part' some (%s and ('inheres_in' some ('lesion' and ('part_of' some %s))) and ('qualifier' some 'abnormal'))
There is always a tension between the flexibility of a pattern and possible issues of interoperability. 3 variables should IMHO be used only in very specific circumstances (relational qualities etc).
I think the generalized pattern we need to agree on here is
Q inheres_in some ( {pathological entity} & R some {anatomical entity})
Should R be part_of or located_in? I favour the latter but this should be decided in co-ordination with Mondo.
If we don't want to subtype lesions (apart from by where they are - which we are specifying here using a compositional entity), then I agree with Nico that we should make a lesion pattern.
There are at least two patterns that one encounters in medicine.
The HPO currently has terms that correspond to (1) (some of the terms). In cancer and in many other areas, it will be important to model phenotypes of category (2) in some way (possibly not as precomposed terms). If we think that we want to use OWL to reason over terms like this, then we should be sure that they will be compatible.
I created a pull request #303 with a suggested pattern to move forward. Any comments and/or corrections on the pattern are welcome and appreciated. I made a note in the comments of the pull request that there are questions about the best relation to use, part_of or located_in.
Sofia
Some POs such as PLANP and MP represent lesions. PLANP in particular needs to represent lesions and their very particular shape. In MP, some lesions are represented as process phenotypes (example: skin lesions).
How do we represent, for example, a star shaped lesion of the tail?
@srobb1, @sbello, @dosumis, @pnrobinson