search

obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

review: lesionInLocationByShape.yaml #364

Open nicolevasilevsky opened 5 years ago

nicolevasilevsky commented 5 years ago

lesionInLocationByShape.yaml

this pattern is going to generate labels like: abnormal head with star lesion

I think the name should be revised to: %s shaped lesion in the %s (which would be consistent with your example: star shaped lesion in the head)

lesion is from NCIT, and we haven't been using NCIT findings in logical definitions to date. Would we be able to import these for use in uPheno patterns, @matentzn

matentzn commented 5 years ago

We will keep this open for a while. I have no answer to that yet; and I dont expect one in the next months. The basic decision we need to reach is: Do we refer at all to pathological entities in our EQs, or will we consider a lesion a pathological characteristic of some normal tissue. We will make it an issue in one of the next calls, but not the next.

srobb1 commented 5 years ago

@nicolevasilevsky your suggested name looks good.