Open chris-grove opened 5 years ago
I think the "process quality" in the logical definition is intended to be "decreased process quality" or there should be another phrase like "and (has_modifier some 'decreased')" or something, otherwise it looks just like the "abnormalBiologicalProcess" pattern with the exception of 'qualifier' instead of 'has modifier'.
Also, I think the "decreased qualitatively %s" sounds a bit awkward. Adverbs don't usually follow the adjectives they modify, in English. Why not just "decreased quality of %s"?
I'm also in search of good patterns for "defective %s" whether %s is a process or an anatomical entity; I suppose this would be the appropriate one for process?
Does "decreased quality" actually have any meaning in our context? What exactly is the use case of this pattern?
After discussing with @matentzn it sounds like this pattern was just intended to group all terms with a decreased quality of some kind. Then perhaps the description should reflect that or be made more general.
Pattern location as of May 7, 2019:
https://github.com/obophenotype/upheno/blob/master/src/patterns/dosdp-dev/abnormallyDecreasedQualityOfBiologicalProcess.yaml
Pattern as of May 7, 2019: