new pattern: abnormallyDetachedAnatomicalEntities

obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.

https://obophenotype.github.io/upheno/

Creative Commons Zero v1.0 Universal

75 stars 17 forks source link

Open sbello opened 4 years ago

sbello commented 4 years ago

we need a pattern to model abnormal detachment of an entity from another entity example: detached Reissner membrane (http://purl.obolibrary.org/obo/MP_0006023) modification of https://raw.githubusercontent.com/obophenotype/upheno/master/src/patterns/dosdp-dev/abnormallyFusedAnatomicalEntities.yaml Just need to swap out fused (PATO:0000642) and replace with detached from (PATO:0001453)

anna-anagnostop commented 3 months ago

Pattern needs to be corrected to:

Use singular form in pattern_name "abnormallyDetachedAnatomicalEntity" (instead of Entities)
classes: detached from: PATO:0001453
def text: "Detachment of the %s from the %s." (remove the word 'and')
equivalentTo text: "'has_part' some ('detached from' and ('inheres_in' some %s) and ('towards' some %s) and ('has_modifier' some 'abnormal'))"
Should this EQ be using 'characteristic of part of' ?

sbello commented 3 months ago

I don't think this would be 'characteristic of part of'. We wouldn't want to say for example that a detached retina was a detached eye.