obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

Protein localisation patterns should use efficacy and not rate #763

Closed matentzn closed 3 years ago

matentzn commented 3 years ago

@rays22 Why are the increased/decreased patterns now' rate' and not 'efficacy'?

I thought we had agreed on efficacy as rate is too specific and we do not typically know the rate of protein localization.

Originally posted by @pfey03 in https://github.com/obophenotype/upheno/issues/762#issuecomment-936709865

matentzn commented 3 years ago

Urgent.

In general, if we make changed to pull requests, never merge before someone reviews @rays22