obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

Fix increased rate of molecular function pattern description #778

Open pfey03 opened 2 years ago

pfey03 commented 2 years ago

Abnormally increased rate of molecular function

Increased functionality of a molecular process, like 'growth hormone secretion' or 'ketone body biosynthetic process'. For example: HP_0000845 'Growth hormone excess' and HP_0001946 Ketosis.

It's MF not BP!!

compare:

Abnormally decreased rate of molecular function

Decreased or reduced functionality of a molecular function, which is a process that can be carried out by the action of a single macromolecular machine, usually via direct physical interactions with other molecular entities, such as binding, catalysis, enzyme activities (like hydrolases, ligases), etc. Example: HP_0002932 'Aldehyde oxidase deficiency'

rays22 commented 6 months ago

I can confirm that the examples in the two 'abnormal molecular function' templates do not actually fit the EQs and thus are incorrect. As you point out, none of these examples are actually molecular function terms. Please, note that the 'HP:0002932 Aldehyde oxidase deficiency' example is also incorrect, because the logical definition calls for a term from the GO molecular_function branch, and a PR term does not fulfil that requirement.

@pfey03 , Can you provide better examples that could be used in the templates?