obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

Add new edematous anatomical entity pattern template #805

Closed rays22 closed 2 years ago

rays22 commented 2 years ago
  1. [x] add new pattern edematousAnatomicalEntity.yaml for review
  2. [x] get feedback
  3. [ ] fix or improve pattern based on feedback
ybradford commented 2 years ago

this looks good to me. ZP uses edematous a lot for example: http://purl.obolibrary.org/obo/ZP_0000038 and http://purl.obolibrary.org/obo/ZP_0001451

It seems the ZP is already using characteristic_of which differs from XPO http://purl.obolibrary.org /obo/XPO_0141324

Orcid id 0000-0002-9900-7880

sbello commented 2 years ago

http://www.informatics.jax.org/vocab/mp_ontology/MP:0001785

srobb1 commented 2 years ago

I definitely want to understand the implications and differences between inheres_in and characteristic_of. I use this template in PLANP and want to make sure it still works for us.

PLANP:0000801 edema in animal PLANP:0000802 head edema PLANP:0000803 tail edema

ORCID 0000-0002-3528-5267

rays22 commented 2 years ago

I definitely want to understand the implications and differences between inheres_in and characteristic_of. I use this template in PLANP and want to make sure it still works for us.

@srobb1 , There is no difference between inheres in and characteristic of in the sense that they both refer to RO:0000052.. characteristic of is the current label of RO:0000052. There is an explanation why the label was changed in the comment section of RO:0000052 here.