search

obophenotype / upheno

The Unified Phenotype Ontology (uPheno) integrates multiple phenotype ontologies into a unified cross-species phenotype ontology.
https://obophenotype.github.io/upheno/
Creative Commons Zero v1.0 Universal
76 stars 17 forks source link

Add new partial pattern to help queries #905

Open rays22 opened 1 year ago

rays22 commented 1 year ago

If applied, this commit will fix #904.

sbello commented 1 year ago

@matentzn I don't think we wanted this to be a term creation pattern, correct? I thought what you wanted was to capture the standard for adding subclass axioms to existing terms to enrich the anatomy cross-references in the ontology. I don't think this should follow the standard set up for a UPheno pattern. Anna and I discussed this with @rays22 at today's meeting

matentzn commented 1 year ago

I think its great to have this as a pattern - remember patterns are not only to "create new terms", but also to capture/document certain modelling decisions. I have some feedback on the PR, but it is definitely good to have these as a pattern.

sbello commented 1 year ago

@matentzn I wasn't suggesting we not have the pattern but just questioning the need to have the term creating parts like name, definition, synonyms in the pattern. Having these here suggests that this pattern could be used to generate a new term and that is not the purpose in this case.

matentzn commented 1 year ago

You are 100% correct on that @sbello - sorry, misunderstood you. @rays22 we only need the subclass axiom template from the generative features.