obophenotype / zebrafish-phenotype-ontology

A vocabulary for describing Zebrafish Phenotypes
https://obophenotype.github.io/zebrafish-phenotype-ontology/
9 stars 3 forks source link

Drafting a plan for pre-coordinating amerliorated an excacerbated phenotypes #59

Open matentzn opened 10 months ago

matentzn commented 10 months ago

Apart from phenotypic abnormalities, ZFIN curates ameliorated and excacerbated phenotypes. These phenotypes are special in two senses

Now the problem is that (1) adding those into ZP will lead to two large branches with 3000 - 9000 terms being added (term proliferation), and (2) there is no integration between the two, or, indeed with anything in uPheno.

My sense is the ship to prevent term proliferation has sailed. We should just add these phenotypes the same way as the we have the others.

However, I do think we should move uPheno to the "changed" qualifier throughout so that we can group ameliorated, exacerbated and abnormal in a more general "phenotype" hierarchy.

rays22 commented 10 months ago

I suspect that ameliorated and exacerbated are related to genetic suppression and enhancement, respectively. If that is the case, then they do imply a change of direction, however, the direction is relative, and not absolute, like increased or decreased, and the direction depends on the reference phenotype. The direction can be towards a normal, average, wild-type or other reference phenotypic state (genetic suppression --> ameliorated phenotype), or in the opposite direction (genetic enhancement --> exacerbated phenotype). Complete suppression reverts to a phenotype to normal, however, partial suppression and genetic enhancement should still be classed abnormal, or at least, deviation from a normal phenotypic state. For example, if a decreased eye size phenotype is partially ameliorated by some combination of genetic alterations, then it implies that the size of the eye still remains smaller (decreased) compared with the eyes of wild-type animals. decreased remains the qualifier in case of genetic enhancement, but the eye size decrease is exacerbated compared with an already abnormal state. Only complete genetic suppression reverts the phenotypic state to normal (assuming that that is the reference state). In my interpretation, ameliorated and exacerbated indicate that the reference phenotype is NOT the wild-type phenotypic state, but the reference is an abnormal (uPheno) phenotype. In my opinion they do/should interact with the phenotypic hierarchy.

Here is what I mean by genetic suppression and enhancement:

ybradford commented 10 months ago

For ZFIN ameliorated and exacerbated phenotypes can be the result of genetic interactions or application of treatments (chemicals, drugs) or both.