search

oborchers / Fast_Sentence_Embeddings

Compute Sentence Embeddings Fast!
GNU General Public License v3.0
616 stars 83 forks source link

Bug in remove_principal_components #35

Closed antklen closed 3 years ago

antklen commented 3 years ago

https://github.com/oborchers/Fast_Sentence_Embeddings/blob/6f9febf806ec321bb0e2f0ad1168fcc7a7f2647e/fse/models/utils.py#L135

For inplace = False function returns projection on principal components instead of resulting vectors.

oborchers commented 3 years ago

Thank you for raising the issue! I will have a look into this

bhargavvader commented 3 years ago

Has this by been fixed? I believe the fix by @grantmwilliams here should do the trick. Should I raise a PR if that makes things easier for you @oborchers ?

grantmwilliams commented 3 years ago

Has this by been fixed? I believe the fix by @grantmwilliams here should do the trick. Should I raise a PR if that makes things easier for you @oborchers ?

https://github.com/oborchers/Fast_Sentence_Embeddings/pull/37 Was merged and should have the fix.

bhargavvader commented 3 years ago

Great!

edit: can this issue be closed?

oborchers commented 3 years ago

Yes! thanks for your contribution