oborchers / Fast_Sentence_Embeddings

Compute Sentence Embeddings Fast!
GNU General Public License v3.0
616 stars 83 forks source link

Don't absorb KeyedVectors into BaseS2V class #62

Open oborchers opened 2 years ago

oborchers commented 2 years ago

Untangling the bad design decision to actually store the BaseKeyedVector from Gensim internally. If users want mmap, they can just load that and pass it. At least we shouldn't store it with the model.