FSE migration to Gensim >=4

oborchers / Fast_Sentence_Embeddings

Compute Sentence Embeddings Fast!

GNU General Public License v3.0

616 stars 83 forks source link

FSE migration to Gensim >=4 #65

Open AleMuzzi opened 2 years ago

AleMuzzi commented 2 years ago

I needed FSE with Gensim >=4 but I was unable to use it due to API compatibility bugs, as discussed in #40 and #43 . I successfully performed the migration and tested it with success with a KNN classification task.

lgtm-com[bot] commented 2 years ago

This pull request introduces 4 alerts when merging a0702e6d2736d5f63aca6982c05b25d6846d1571 into 672e2c594592c808045d262325ea4e32bc7f830d - view on LGTM.com

new alerts:

3 for Wrong name for an argument in a class instantiation
1 for Unused import

AleMuzzi commented 2 years ago

Tests still needs to be migrated, leaving these to the repo developers

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 219c2aea9d4d7d642d0cae0d95a7fd19cfc1b1d9 into 672e2c594592c808045d262325ea4e32bc7f830d - view on LGTM.com

new alerts:

1 for Signature mismatch in overriding method
1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging ebcf9b48d9a11a33c62cd120c6d46407a5a1cb67 into 672e2c594592c808045d262325ea4e32bc7f830d - view on LGTM.com

new alerts:

1 for Module is imported with 'import' and 'import from'

oborchers commented 2 years ago

@AleMuzzi merged 4.0.0 support. However, I am also going to look into your TfIDF implementation as well, which looks good to me 👍

AleMuzzi commented 2 years ago

@AleMuzzi merged 4.0.0 support. However, I am also going to look into your TfIDF implementation as well, which looks good to me 👍

Very well, glad to know that 💪