Open cthoyt opened 5 years ago
Are these still needed?
Yes I'm still interested in adding additional relationships (and reverse relationships). I'll update the issue header with some more information
Is this now done?
It appears there are some issues with the build and these new terms are not being propagated. Unfortunately, of the issues/PRs/commits that were a follow-up to #521 are very cryptic:
The new termsin the ro-edit.owl
don't appear to be in the release files. e.g., a search in https://github.com/oborel/obo-relations/blob/master/ro.obo for myristolates
currently shows nothing. Does this also means there's an overall problem with the build?
cc @anitacaron
I'll look into the ODK migration branch I've been working on if the issue is still there.
@cthoyt I checked the IDs created in PR #586 and I could found in the last RO release. Try to search for myristoylates
.
Yes, but that one was done by hand - I mean the remaining ones that we curated in https://github.com/oborel/obo-relations/blob/master/src/patterns/ro-interaction-relations-src.yaml to be generated via template are not getting propogated
Ok, I see it's a LinkML template, which we don't have in ODK. I could move the targets in the src/patterns/Makefile
to ro.Makefile
and generate the component. What do you think, @matentzn?
In case you missed it, the components are already generated in https://github.com/oborel/obo-relations/blob/master/src/patterns/ro-interaction-relations.ofn and https://github.com/oborel/obo-relations/blob/master/src/patterns/ro-interaction-relations.owl as an example
Yes, they need to be moved to the components folder properly.
As an addition to RO:0002447 (phosphorylates) and RO:0002480 (ubiquitinates), that occur under RO:0002436 (molecularly interacts with), I would suggest adding relationships for the following post-translational modifications, which all have corresponding functions with the Biological Expression Language (BEL) as well as corresponding Gene Ontology terms in the molecular function namespace:
There are also several other entries in cellular protein modification process (e.g., amination, nitration, polyamination, nitrosylation, neddylation, sumoylation, etc.) but let's just start by thinking about a couple concrete ones :)
I think many of these make sense following the form proposed by @cmungall (see: https://github.com/oborel/obo-relations/issues/259#issuecomment-424472190) with the addition of
mf
to represent one of these molecular functions that are a cellular protein modification process:One caveat: a couple of these aren't "activities" but come from the "binding" tree. I'm also curious how one would handle those.