search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 47 forks source link

Consider "modifies frequency or severity of condition" instead of "contributes to condition" for RO:0003304 #289

Open kshefchek opened 5 years ago

kshefchek commented 5 years ago

Currently RO has the term "contributes to condition" which is a parent of:

If we are grouping preventative/positive effects under this relation, it may make more sense for the label to reflect this. Consider "modifies condition" or "modifies frequency or severity of condition."

phismith commented 5 years ago

'frequency of condition' doesn't make much sense -- when we talk of frequency we are talking about outbreaks, or something like that

'modifies' is, though, an improvement over 'contributes to'. I suggest

modifies condition modifies severity of condition

-

BS

On Fri, Nov 30, 2018 at 1:38 PM Kent Shefchek notifications@github.com wrote:

Currently RO has the term "contributes to condition" which is a parent of:

  • contributes to frequency of disease
  • contributes to severity of condition
    • ameliorates condition
    • exacerbates condition

If we are grouping preventative/positive effects under this relation, it may make more sense for the label to reflect this. Consider "modifies condition" or "modifies frequency or severity of condition."

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/oborel/obo-relations/issues/289, or mute the thread https://github.com/notifications/unsubscribe-auth/AH6qN2c346_J-3-0_Y_pmCZithkLk-Mmks5u0XrrgaJpZM4Y8Ljw .

nlharris commented 2 years ago

Is this still needed?

github-actions[bot] commented 2 months ago

This issue has not seen any activity in the past 2 years. It will be closed automatically 60 days from now if no action is taken.

github-actions[bot] commented 3 weeks ago

This issue has been closed automatically because it has not been updated in over two years. Please re-open if you still need this to be addressed.

sierra-moxon commented 3 weeks ago

I re-opened this issue because I think the proposal from @kshefchek and @phismith improves the relations noted. I guess I am upvoting this issue.