search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 47 forks source link

added has completed and has not completed #577

Open shawntanzk opened 2 years ago

shawntanzk commented 2 years ago

Fixes #574

dosumis commented 2 years ago

CC @addiehl

cmungall commented 2 years ago

you will need to resolve conflicts

commens on the relation in the ticket...

cmungall commented 2 years ago

What is the status of this - I see a lot of discussion on the issue but not clear if this is ready to be merged?

shawntanzk commented 2 years ago

What is the status of this - I see a lot of discussion on the issue but not clear if this is ready to be merged?

lol, good question. From reading I think theses are the possible solutions:

  1. has_completed -> output_of (this can be done with all the options below)
  2. make an annotation property for has_not_completed that expands to have the negative (not 100% sure how to handle this personally)
  3. use capable_of instead of has_not_completed (downside is that we have to make sure individual changes make sense, and reasoner won't work well here)

I've converted this to draft as I think we are using this more as a discussion point, happy to implement stuff once we have a clear direction (thought I guess that is the difficult part)