search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 46 forks source link

Attribution Cleanup #664

Closed cthoyt closed 1 year ago

cthoyt commented 1 year ago

I've been meaning to demonstrate that doing what @cmungall suggested in https://github.com/cthoyt/orcidio/issues/5 was feasible. This PR consists of about a half hour of find/replace in the ro-edit.owl file in a text editor where I replaced string mentions of people's names in provenance fields with canonical ORCID identifiers as URIs. I put a decent debt in this repository's provenance debt (i.e., turning unstructured provenance into structured provenance).

If this PR is accepted, here are some future to-do's:

  1. Continue updating the remaining instances dc, dcterms, dce, and iao annotations that point to individuals
  2. Import ORCIDIO so all of these beautiful, clean ORCID identifiers get names overlayed when editing in Protege
  3. After finishing 1) to completion, add additional unit tests to make sure nobody ever adds unstructured information again (@matentzn I hope you could help introduce this one predicate at a time, perhaps starting with IAO_0000117 since this is fully cleaned up now)
cooperl09 commented 1 year ago

This looks correct? https://orcid.org/0000-0001-6996-0040

cthoyt commented 1 year ago

This looks correct? https://orcid.org/0000-0001-6996-0040

Thanks! Updated in 0c12077