Closed diatomsRcool closed 1 year ago
@diatomsRcool I added habitat
as the range of has habitat
. This change should propagate down to has roost
. Can you confirm the range should be habitat
?
I also change the dc:creator
annotation to dcterms:contributor
. @cthoyt Is this the current protocol for term attribution.
I'm not sure if we have a concrete choice on which predicate should be used, other than it should be DCTERMS and not DCE. Contributor is probably fine!
Thanks @cthoyt
@diatomsRcool you can change to dcterms:creator
if you wish. I was going off my experience with uberon.
@cthoyt @diatomsRcool I think this is ready to merge. Please let me know if you disagree.
sorry I don't want to hold this up, but there was never any engagement with my request to get a concrete example. Can someone please suggest an actual example? Like "this kind of bird has roost on this kind of tree"? @diatomsRcool do you understand what I am asking? I just want an actual example of a bird and a tree.
Flying foxes (Pteropus giganteus) roost in a banyan tree (Ficus benghalensis). Is that what you need?
@diatomsRcool yes, that's perfect! You can annotate that on to the property with http://purl.obolibrary.org/obo/IAO_0000112 (example of usage)
@diatomsRcool I will merge after you provide the example of usage.
@wdduncan it seems you’ve merged before QC was passing, I would suggest immediately reverting this and @matentzn fixing the branch protection rules
@cthoyt Yes ... I did :(
I think the the violation concerns the use of dc elements.
Here is the sparql.
Added new object property "has roost" as child of "has habitat" to address issue #453