oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 46 forks source link

added new object property has roost for issue #453 #672

Closed diatomsRcool closed 1 year ago

diatomsRcool commented 1 year ago

Added new object property "has roost" as child of "has habitat" to address issue #453

wdduncan commented 1 year ago

@diatomsRcool I added habitat as the range of has habitat. This change should propagate down to has roost. Can you confirm the range should be habitat?

I also change the dc:creator annotation to dcterms:contributor. @cthoyt Is this the current protocol for term attribution.

cthoyt commented 1 year ago

I'm not sure if we have a concrete choice on which predicate should be used, other than it should be DCTERMS and not DCE. Contributor is probably fine!

wdduncan commented 1 year ago

Thanks @cthoyt
@diatomsRcool you can change to dcterms:creator if you wish. I was going off my experience with uberon.

wdduncan commented 1 year ago

@cthoyt @diatomsRcool I think this is ready to merge. Please let me know if you disagree.

cthoyt commented 1 year ago

sorry I don't want to hold this up, but there was never any engagement with my request to get a concrete example. Can someone please suggest an actual example? Like "this kind of bird has roost on this kind of tree"? @diatomsRcool do you understand what I am asking? I just want an actual example of a bird and a tree.

diatomsRcool commented 1 year ago

Flying foxes (Pteropus giganteus) roost in a banyan tree (Ficus benghalensis). Is that what you need?

cthoyt commented 1 year ago

@diatomsRcool yes, that's perfect! You can annotate that on to the property with http://purl.obolibrary.org/obo/IAO_0000112 (example of usage)

wdduncan commented 1 year ago

@diatomsRcool I will merge after you provide the example of usage.

cthoyt commented 1 year ago

@wdduncan it seems you’ve merged before QC was passing, I would suggest immediately reverting this and @matentzn fixing the branch protection rules

wdduncan commented 1 year ago

@cthoyt Yes ... I did :(

I think the the violation concerns the use of dc elements.

image

Here is the sparql.

image