oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 46 forks source link

NTR: owns; is owned by #674

Closed CDowland closed 4 months ago

CDowland commented 1 year ago

NTR 1: Label: owns Elucidation: x owns y if and only if y is at x’s full disposal. This primitive relation is the foundation of the owner’s right to have the owned entity at his/her full disposal.
Definition editor: Mathias Brochhausen

NTR 2: Label: is owned by Definition: The inverse of owns. Definition editor: Mathias Brochhausen

wdduncan commented 1 year ago

@CDowland I've added to the 01/31/2023 agenda.

cstoeckert commented 1 year ago

Note that these relations are currently in OBIB (http://purl.obolibrary.org/obo/OBIB_0000732, http://purl.obolibrary.org/obo/OBIB_0000735) and originated from OMIABIS (which has been integrated into OBIB). OBIB is asking for these relations to be included in RO as per OBOF principles.

cthoyt commented 1 year ago

@CDowland can you give some concrete examples that use these relationships (including CURIEs for subject/object)?

StroemPhi commented 1 year ago

an example proposal of me owning this particular record box: https://www.discogs.com/de/user/wan.2 ro:owns https://www.discogs.com/de/release/4218752-QNS-QNS-Box

wdduncan commented 1 year ago

An example from OBIB would be helpful.

StroemPhi commented 1 year ago

Axioms from OBIB that use these two relations copied from Ontobee and reformated for better readabilty:

wdduncan commented 1 year ago

The next RO call is March 28, 2023 at 9am PT, 18:00 CET. It would be great if you could attend.
Here is the Zoom link.

CDowland commented 1 year ago

@cthoyt In addition to the above examples:

Where a person X owns both a mobile phone Y and a house Z: X instance of NCBITaxon:9606 Y instance of ENVO:01000581 Z instance of ENVO:01000417 X owns Y (or Y owned by X) X owns Z (or Z owned by X)

@wdduncan Thanks, I will add it to my calendar.

wdduncan commented 1 year ago

Thanks @CDowland !

cstoeckert commented 1 year ago

Examples discussed on March 2, 2023 OBIB call: biobank organization owns a specimen hospital owns a laboratory facility CT scanner is owned by hospital freezer is owned by a biobank organization

zhengj2007 commented 1 year ago

@wdduncan Can I know the domain and range of the relations? Thanks!

wdduncan commented 1 year ago

@zhengj2007 That is a good question. I don't know the answer ... I was going off the ticket.

@CDowland Do you know?

CDowland commented 1 year ago

In OBIB the domain of owns is:

'Homo sapiens' or organization or 'collection of humans' or 'aggregate of organizations'

And its range is:

'material entity' or 'information content entity'

For is owned by those are swapped.

zhengj2007 commented 1 year ago

If we want replace the OBIB one with RO one, it would be better to keep the domain and range defined in the OBIB and also copy over the OBIB definition. How do you think @wdduncan ?

CDowland commented 1 year ago

@zhengj2007 Do you mean using the current OBIB definition instead of the one requested here? We don't want that. We made the above definition for the purpose of this request, and it is a revised version of what's currently in OBIB.

Or do you mean including it as an additional annotation (something other than definition)?

zhengj2007 commented 1 year ago

The current Definition is: 'The inverse of owns.'. I'd prefer to use descriptive definition and use inverse axiom to indicate it is the inverse relation of owns. @CDowland

wdduncan commented 1 year ago

@zhengj2007 Nice catch about the inverse of axiom! I've added it to the PR.

As for the definition of is owned by, it is standard practice for the inverse definition to state that it is an inverse. E.g. see active ingredient in.

If you want a more verbose definition, please supply one :)

CDowland commented 1 year ago

Sorry for the misunderstanding. I was mixing up the two requested terms.

If a descriptive definition is preferable, then instead of importing the old OBIB one, perhaps making it more closely mirror the definition of 'owns' would be better:

y is owned by x if and only if y is at x’s full disposal. This primitive relation is the foundation of the owner’s right to have the owned entity at his/her full disposal.

As for whether to use that or instead stick with the requested one, I'm neutral.

wdduncan commented 1 year ago

Adding @matentzn to the thread regarding adding classes for domains/ranges.
We would need to import the classes: 'Homo sapiens' or organization or 'collection of humans' or 'aggregate of organizations'.

Is this handled through ODK or do we manually add the classes to other_imports.owl?

zhengj2007 commented 1 year ago

@CDowland It's fine. OBIB does not have relation 'owns'.

wdduncan commented 1 year ago

@CDowland I add the definition for owns as:

A primitive relation the holds between entities x and y in which y is at x’s full disposal.

RO does not have an elucidation annotation. I have found the if and only if locution to be confusing to users that aren't familiar with FOL.

I also added a dcterms:description annotationation:

This primitive relation is the foundation of the owner’s right to have the owned entity at his/her full disposal.
CDowland commented 1 year ago

@zhengj2007 OBIB currently has both 'owns' and 'is owned by': http://purl.obolibrary.org/obo/OBIB_0000732, http://purl.obolibrary.org/obo/OBIB_0000735

@wdduncan "the holds" should be "that holds." Otherwise, it looks good to me.

zhengj2007 commented 1 year ago

@CDowland Thanks for catching it.

wdduncan commented 1 year ago

@wdduncan "the holds" should be "that holds." Otherwise, it looks good to me.

Thanks. Typo was fixed. See change

Added OBIB:0000735 as source for owns. See change

zhengj2007 commented 1 year ago

Thanks @wdduncan

nlharris commented 11 months ago

can this be closed?

wdduncan commented 11 months ago

Not yet. The PR is still open.