search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 46 forks source link

Ensure provenance relations are used with ORCID or other appropriate IRIs #690

Closed cthoyt closed 1 year ago

cthoyt commented 1 year ago

This check should ensure that IAO:0000117 (term editor), dc:contributor, dc:creator, and oio:created_by all have appropriate ORCID/Wikidata/ROR IRIs. I also did all of the curation it took to pass this check.

This is based on @anitacaron's suggestion from UBERON/CL: https://github.com/obophenotype/uberon/blob/master/src/sparql/orcid-contributor-violation.sparql

cmungall commented 1 year ago

Thanks @cthoyt !

This makes ro statistics look much cleaner:

...
  orcid:0000-0002-6601-2165:
    contributor_id: orcid:0000-0002-6601-2165
    role_counts:
      IAO:0000117:
        facet: IAO:0000117
        filtered_count: 260
      dcterms:contributor:
        facet: dcterms:contributor
        filtered_count: 2
      dcterms:creator:
        facet: dcterms:creator
        filtered_count: 7
      oio:created_by:
        facet: oio:created_by
        filtered_count: 46
  orcid:0000-0002-7073-9172:
    contributor_id: orcid:0000-0002-7073-9172
    role_counts:
      IAO:0000117:
        facet: IAO:0000117
        filtered_count: 38
      dcterms:contributor:
        facet: dcterms:contributor
        filtered_count: 1
      oio:created_by:
        facet: oio:created_by
        filtered_count: 15
...

I would like to also normalize on dcterms:contributor (see https://github.com/information-artifact-ontology/ontology-metadata/issues/120 where I was convinced of this). But this can be a separate PR! onwards!