search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 46 forks source link

Replace all uses of DCE with DC and add violation check #692

Closed cthoyt closed 1 year ago

cthoyt commented 1 year ago

Closes #691

This PR does the following:

  1. Replaces all remaining uses of DCE with DC
  2. Removes the DCE prefix from the definitions and clean up corresponding declarations
  3. Adds a violation check to make sure no predicates use the URI prefix for DCE

When you run sh run.sh make sparql_test, there should be no errors.

matentzn commented 1 year ago

Ready to merge after conflict resolution

cthoyt commented 1 year ago

@matentzn merge/conflict resolution is done. Next steps:

  1. Upstream these QC profiles into ODK
  2. How do we ensure that sparql_test is run as part of QC for pull requests?
matentzn commented 1 year ago

Upstream these QC profiles into ODK

PR here: https://github.com/INCATools/ontology-development-kit/tree/master/template/src/sparql

How do we ensure that sparql_test is run as part of QC for pull requests?

It always is:

https://github.com/oborel/obo-relations/pull/692/checks#step:4:26