oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
91 stars 46 forks source link

NTR: owns; is owned by #705

Closed wdduncan closed 4 months ago

wdduncan commented 1 year ago

Fixes #674

wdduncan commented 1 year ago

@mbrochhausen @CDowland @zhengj2007 I've add the terms.
Note: RO doesn't have an elucidation AP. So, I took some liberties with the definition.

Who do you suggest to review?

zhengj2007 commented 1 year ago

I recommended @mbrochhausen.

zhengj2007 commented 1 year ago

@wdduncan Could you also use the inverse of axiom to indicate that owns is inverse relation of 'is owned by' and vice versa? Besides, here is the definition of OBIB:0000735 is owned by in OBIB: A is owned by b if b has complete power over a. All rights and obligations of ownership are grounded in this (primitive) relation. The claims and obligations of ownership can be partially transferred to a third party by the owner, b. Can we also add it in the RO and indicate the definition coming from OBIB:0000735 use 'definition source' ? Thanks!

wdduncan commented 1 year ago

@zhengj2007 I added the inverse of axiom for owns and is owned by, and the definition source (dcterms:source) for is owned by as OBIB:0000735.

As for the definition of is owned by, the wording is different. It uses the phrase "complete power", where as the definition for owns uses the phrase "full disposal". These seem subtly different to me.

Also, "complete power" seems a bit strong. I own my dog, but I don't have complete power over him.

wdduncan commented 1 year ago

@wdduncan I need to change the IRI. This PR has been open so long that I forgot about it, and accidentally used the IRI.

github-actions[bot] commented 8 months ago

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

wdduncan commented 8 months ago

I think this is ready. @CDowland What do you think?

wdduncan commented 5 months ago

@anitacaron I am in the oridio on Charley's github site. So, is there an import problem for RO? What needs to be done to update the RO ordicio?

anitacaron commented 5 months ago

@wdduncan, did you try to run sh run.sh make imports/orcidio_import.owl

wdduncan commented 5 months ago

@wdduncan, did you try to run sh run.sh make imports/orcidio_import.owl

Yes. I did. However, I wasn't added to the new ocridio_import.owl file.

wdduncan commented 5 months ago

Thanks @anitacaron!

@cmungall @cthoyt @CDowland can you please review.

wdduncan commented 4 months ago

@balhoff @CDowland can you please review this? It would be nice to get this merged before the next RO release.

CDowland commented 4 months ago

@wdduncan I did a review/approval yesterday as requested, but it's still showing that another is required. It says "reviewers with write access," which I don't think includes me.

wdduncan commented 4 months ago

@cthoyt @balhoff @zhengj2007 @cmungall @matentzn @jamesaoverton @lschriml
Can one of you please review this PR?

zhengj2007 commented 4 months ago

@wdduncan Could you please update the dcterms:source for 'owns'? It should be OBIB:0000732.

Since I was not assigned as the reviewer, I cannot review and approve the request.

mbrochhausen commented 4 months ago

Based on the OBIB discussion, we do not need the DCterms: source.

wdduncan commented 4 months ago

@zhengj2007 can you please approve this PR.

zhengj2007 commented 4 months ago

@zhengj2007 can you please approve this PR.

@wdduncan Could you please assign me as a reviewer? Thanks!

wdduncan commented 4 months ago

@zhengj2007 I can't add you as a reviewer. It seems that you are not a member of obo-rel repo ... sorry I thought you were.

@anitacaron Can I add her so that she can review this PR? If so, what level of permissions does Jie need?

anitacaron commented 4 months ago

@wdduncan I added @zhengj2007 with a 'write' role; we need to wait for her to accept the invite to add her as a reviewer here.

wdduncan commented 4 months ago

Thanks @anitacaron!

zhengj2007 commented 4 months ago

@wdduncan I added @zhengj2007 with a 'write' role; we need to wait for her to accept the invite to add her as a reviewer here.

@anitacaron Thanks for invitation. @wdduncan I have accepted the invitation. You can assign me to review the request now.

wdduncan commented 4 months ago

Thanks Jie. I assigned you as a reviewer.

wdduncan commented 4 months ago

@zhengj2007 I believe @mbrochhausen said that the dcterms:source annotation was not needed for the owns/is owned by. Am I misunderstanding you @mbrochhausen .

AFAIK, dcterms:source is not required. If you think it is required can you please add it.

zhengj2007 commented 4 months ago

@zhengj2007 I believe @mbrochhausen said that the dcterms:source annotation was not needed for the owns/is owned by. Am I misunderstanding you @mbrochhausen .

AFAIK, dcterms:source is not required. If you think it is required can you please add it.

@wdduncan Yes. However, it is still in ro-edit.owl. So, it should be either removed or corrected if you want to keep it.

wdduncan commented 4 months ago

Ah ... okay. Sorry @zhengj2007 I misunderstood you :)

I removed the dcterms:source annotation for the definition of is owned by. image

zhengj2007 commented 4 months ago

@wdduncan There is dcterms:source associated with 'owns' need to be removed too.

Screenshot 2024-03-04 at 11 26 43 AM
wdduncan commented 4 months ago

Thanks @zhengj2007!
I removed it.

zhengj2007 commented 4 months ago

Actually 4 reviewers approved this pull request. Don't know why it only shows 1 approval.