oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
91 stars 46 forks source link

Clean up files #725

Closed anitacaron closed 1 year ago

anitacaron commented 1 year ago

Fixes #682

They were moved to src/ontology/components in the ODK Migration.

I kept the changes files for historical purposes.

Moved to src/ontology/imports during ODK Migration.

Removed.

Not used as import in anywhere. Moved to src/ontology/attic where other similiar files lives.

wdduncan commented 1 year ago

The BFO classes no longer have labels. E.g.:

image

Are you moving the BFO classes to another import? They should not be deleted if they are being used.

anitacaron commented 1 year ago

The files I removed are at the root level. The same files are in the src/ontology/components.

It's not showing the labels because it's missing the declaration of these files in the catalog. Damien has fixed that in this commit.

cthoyt commented 1 year ago

this is really really bad, look at the commit history

Screenshot 2023-06-26 at 23 04 38

we have a commit to the main branch that breaks it. then this one on top of it, adding to the issues. I think we need to hard reset to 2 commits on master ago to the last non-broken commit and immediately enforce protection on main branch that CI has to pass