search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
91 stars 46 forks source link

Issues remaining after #732 #733

Closed cthoyt closed 11 months ago

cthoyt commented 1 year ago

Because of the decision to do many PRs that conflated revers and updates, it was very difficult to find issues. Here's what I found so far

  1. Merge conflict left sitting here (should be handled by CI) https://github.com/oborel/obo-relations/blob/97a906a4d3d6ac2b44339f1928a0d2555523dc49/src/ontology/catalog-v001.xml#L22
  2. Non HTTPS orcid url (should be handled by CI) https://github.com/oborel/obo-relations/blob/97a906a4d3d6ac2b44339f1928a0d2555523dc49/src/ontology/ro-edit.owl#L6485
  3. Five spurious ^^xsd:dateTime added (these are actually correct, but not it's frustrating that they just showed up during the recent mess)
anitacaron commented 1 year ago

The item 3 is correct this way. If there're properies of type date whithout the datatype xsd:dateTime, it'll be read as string which is wrong.

wdduncan commented 1 year ago

Can this be closed now?

anitacaron commented 1 year ago

No, we still need to fix these minor issues.