search

oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 47 forks source link

Adding the now deprecated relation "has dividend entity" from PATO #775

Closed LarsVogt closed 7 months ago

LarsVogt commented 10 months ago

For new term requests, please provide the following information:

Preferred term label

has dividend entity

Synonyms

has dividend

Textual definition

A relationship between a ratio or proportion and its dividend.

Suggested parent term

RO

Attribution

https://orcid.org/0000-0002-8280-0487

LarsVogt commented 10 months ago

This issue relates to the issue https://github.com/pato-ontology/pato/issues/454 in PATO. Nico told me to ask @anitacaron for help adding this.

nataled commented 10 months ago

Can have 'has numerator' as synonym, or maybe even primary label ('dividend' brings to mind payment from investments, in case we want to avoid that).

ddooley commented 10 months ago

I'd second calling it "has numerator". No need for word "entity" esp as that makes it sound like a class of thing that has a dividend. Similarly for divisor -> "has denominator". Divisor/dividend sound like they are part of a division process; whereas ratios can be expressed as numerator/denominator. (Tho it seems they're all going out of style since 2010, related to math education?! https://books.google.com/ngrams/graph?content=divisor%2Cdividend%2Cnumerator%2Cdenominator&year_start=1900&year_end=2019&corpus=en-US-2019&smoothing=0)

LarsVogt commented 10 months ago

"has numerator" and "has denominator" sound good. I am not a native speaker, so whatever labels you think fit best.

rays22 commented 7 months ago

This relationship would be relevant to model phenotypic traits, for example, the traits that represent the ratio of urinary sodium to potassium concentration in biological samples, or the waist circumference to height ratio.

Similar relationships are used to model ratio-related plant phenotypic traits and attributes, e.g.TO:0000278 root to shoot ratio :

  1. TO:has_dividend_quality
  2. TO:has_divisor_quality

Regarding the label or synonyms, both has numerator and has dividend look fine to me.

Maybe also add a new arithmetic relationship to group this and any related relationships.

nataled commented 7 months ago

Interestingly, going through some old work of mine that didn't progress, I created a placeholder relation 'has numerator' (and its counterpart, 'has denominator'). Can we use these terms as the preferred label? I did a google search:

numerator denominator: 54 million hits
dividend divisor:       5.3 million hits

Looks like the world prefers those labels too :)

Applies to #774 also.