oborel / obo-relations

RO is an ontology of relations for use with biological ontologies
http://oborel.github.io/
Other
92 stars 47 forks source link

Remove redundant domain in `occurs in` (BFO:0000066) #797

Closed anitacaron closed 5 months ago

anitacaron commented 6 months ago

Yes, but the result is that the actual domain is the intersection of the two. In this case BFO:0000015 is a subclass of BFO:0000003, so the actual domain is just BFO:0000015.

_Originally posted by @balhoff in https://github.com/oborel/obo-relations/pull/795#discussion_r1551958498_

anitacaron commented 6 months ago

The domain BFO:0000015 comes from COB import. I found this PR when it was added in cob.owl and cob-base-reasoned.owl three years ago.

Today, it's only available in cob.owl.

https://github.com/OBOFoundry/COB/blob/9bf639a1ebff2f06988938f74681984a5f6d59ca/cob.owl#L129-L135

The domain defined in RO core.owl is BFO:0000003.

https://github.com/oborel/obo-relations/blob/f0994da3b621d7284848abb02803d5f7f27a3ac0/src/ontology/components/core.owl#L193-L213

Should we update the domain in RO or remove the inferred one in COB?