obrona / pe

0 stars 0 forks source link

Adding 2 spaces to a role of a contact causes screen job string matching to fail #13

Open obrona opened 4 days ago

obrona commented 4 days ago

Make sure TalentConnect has at least 1 contact with role as software engineer and 1 job with name software engineer

With role as software engineer

Screenshot 2024-11-15 173538.png

With role as software engineer note the additional space, use the edit command i.e edit contact 1 r/software engineer

Screenshot 2024-11-15 173630.png

Result of screen job 1 is empty

Screenshot 2024-11-15 173658.png

nus-se-bot commented 11 hours ago

Team's Response

Note: We will use , to denote white space.

We do understand where you are coming from. However, currently the screen job command is working as intended, as we are performing the screening task currently by seeing if 'role' is a sub-string of the job name. Hence Software,,Engineer is not considered a sub-string of Software,Engineer,Lead as it has an additional white-space. Software,,Engineer will still match with Software,,Engineer,Lead as such.

We have identified that as a possible enhancement within our DG, which is to improve our screen job function from having the entire role be a partial match for the job name to allowing the role be split into elements and see if those elements are partial matches as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that this is a feature flaw, and not a functionality bug, but it is a relevant feature flaw.

Users, who are not tech trained, reading the developer guide may not know that for contact role, the entire string is treated as one, including words separated by white spaces. It is reasonable for users to assume that words separated by white spaces are treated as separate words, and the 2 words software and engineer are valid sub-strings of Software Engineer, Google Pay, Core (ignoring whether words are small caps or capital caps).

Furthermore, the role contains 'all elements' of the job name. This DG, under planned enhancements, stated that screening for roles that have 'partial elements' will be supported in the future

Here are detailed steps to produce the bug

Steps

  1. Start from a fresh copy of TalentConnect i.e. delete the data folder, if it exists
  2. Ensure the 1st index of contact has a role of software engineer, with 2 or more spaces between the 2 words. Use edit contact to change the default value. Ensure the 1st job has a name of Software Engineer, Google Pay, Core. This should already be displayed in the app right from the start.

Picture

Screenshot 2024-11-19 134358.png

  1. type screen job 1

Expected

Alex Yeoh will be displayed

Actual

No matching candidate found image.png

Another example

Steps

  1. Start from a fresh copy of TalentConnect i.e. delete the data folder, if it exists
  2. Ensure the 1st index of contact has a role of snr software engineer Use edit contact to change the default value. Ensure the 1st job has a name of Software Engineer, Google Pay, Core. This should already be displayed in the app right from the start.

Picture

Screenshot 2024-11-19 124253.png

  1. type screen job 1

Expected

Alex Yeoh will be displayed

Actual

No matching candidate found

In this case, software engineer from snr software engineer is a valid sub-string of Software Engineer, Google Pay, Core. It is reasonable for users to assume that software engineer is used as a sub-string for job names to check for a match, since the DG did not state that the entire role value is treated as a single string.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This feature flaw can cause occasional inconvenience for recruiters, as the lack of clear explanation of how screen job works (that the entire role value is treated as a single string) is not stated explicitly. Hence, they might not be able to effectively match candidates to the jobs.