search

obs-websocket-community-projects / obs-websocket-js

Consumes https://github.com/obsproject/obs-websocket
MIT License
667 stars 96 forks source link

Add support for secure websockets #201

Closed Niek closed 3 years ago

Niek commented 4 years ago

Related Issue (if applicable): #195

Description:

This PR adds support for secure websockets. This is very useful when running obs-websocket behind a proxy like ngrok. This allows OBS to be controlled from HTTPS websites.

Niek commented 4 years ago

Sample code:

await obs.connect({ address, password, secure: (location.protocol === 'https:') });
Niek commented 4 years ago

@haganbmj can you merge this?

chmaltsp commented 4 years ago

Would love to see this merged as well

Niek commented 4 years ago

@haganbmj are you still maintaining this?

rodrigograca31 commented 3 years ago

Looks like good code.

The maintainer is not responsive at the moment... I also have a PR waiting...

haganbmj commented 3 years ago

Sorry, you're correct that I haven't been actively maintaining this. Did obs-websocket add support for wss? I haven't looked at that either in a while.

At some point in the past I stopped using OBS regularly and my interest waned. I had handed it off to Lange when they seemed adamant that adding typings to this was beneficial, but I think he might be inactive as well. I can merge this, but I'll also need to go through and check if the test + deploy jobs are working - I wouldn't be surprised if some of my access tokens for npm expired.

haganbmj commented 3 years ago

Oh just reread your post about deploying behind ngrok, gotcha now on when wss is an option. Merged and trying a release job now.

haganbmj commented 3 years ago

image

Eh, npm looks happy enough. I'll have a look through the other PRs, including yours Rodrigo.

Niek commented 3 years ago

Excellent, thanks a lot @haganbmj

If you don't have time to maintain the repo I'd be happy to help you out. I'm depending on this library in my https://github.com/Niek/obs-web repo

rodrigograca31 commented 3 years ago

@haganbmj thanks for your hard work!

I'm also happy to be a contributor and help. That's why I commented on this thread yesterday: :sweat_smile: I'm already a contributor to many open-source projects and npm package publisher.

@Niek Didn't know about your project! Looks super nice! I've used your "competition" (t2t2/obs-tablet-remote) 😂 😂 because they are linked in the main obs-websocket project. You should get yours linked there too! Shall I send them a PR?

Niek commented 3 years ago

Thanks @rodrigograca31 - yes if you can do a PR there that would be nice.

rodrigograca31 commented 3 years ago

done. https://github.com/Palakis/obs-websocket/pull/592

Niek commented 3 years ago

@haganbmj let me know if me or @rodrigograca31 can help with maintaining this repo. It would be nice to get some PRs merged.