Closed haganbmj closed 2 years ago
Seems you started doing what I was about to try to do because you got many dependencies outdated.
This is the output of ncu:
red indicates a major version is available. seems you are bumping to minor versions only. I was about to bump to major ones...
Yeah, I scaled down the initial set of version bumps to try and track down the failure. Once I correct that I can actually start applying the rest, including the majors. The build job should be failing if it were properly looking at the TS tests.
Yeah, the best thing would be to bump everything to the latest eventually...
Btw, I dont know why but if I run npm run test:types
on your branch if fails with a bunch of errors... but here on the PR page I see everything is green......... 🤔
@haganbmj Hi!
Do you have an eta on when you will merge this? 🤔
@haganbmj another +1 from me :)
Frankly I don't know how the typescript setup on here is configured. There appears to be a version mismatch occurring somewhere, which I originally thought was to do with either forcing es6 or explicitly targeted Typescript 3.1. Apparently the ts tests can also fail while still passing the build, so that's another issue to go work out. This currently builds the type definitions correctly, but fails their tests.