obs-websocket-community-projects / obs-websocket-js

Consumes https://github.com/obsproject/obs-websocket
MIT License
657 stars 95 forks source link

Renaming GetGroupItemList to GetGroupSceneItemList #294

Closed i-false closed 1 year ago

i-false commented 1 year ago

Description:

I had a type error with the "GetGroupItemList" request. After looking around, found out that it is "GetGroupSceneItemList" for v5

reference: https://docs.google.com/spreadsheets/d/1LfCZrbT8e7cSaKo_TuPDd-CJiptL7RSuo8iE63vMmMs/edit#gid=1402923009

t2t2 commented 1 year ago

types.ts is autogenerated from obs-websocket provided protocol.json on new releases of obs-websocket. This typo was fixed a week after 5.0.0 release

@tt2468 is 5.0.1 gonna be released soon considering the version bump commit? (If it is then I'd just wait for that since I'd run the update script anyway)

t2t2 commented 1 year ago

merging as code tagged as 5.0.1 (in a separate branch from master) didn't include the correction

tt2468 commented 1 year ago

Ah sorry for not responding to this, I knew there was somewhere I got pinged with a question.