search

observablehq / feedback

Customer submitted bugs and feature requests
42 stars 3 forks source link

Red error messages are not cleared after I fix a bug in a notebook #418

Open tomlarkworthy opened 2 years ago

tomlarkworthy commented 2 years ago

Describe the bug context: If a cell throws an error it shows it as red. Downstream cells also highlight the source of the error, in red, and display "jump to error".

If I fix the error cell, the downstream one does not clear unless it evaluate to a concrete value, so if it returns "invalidation", then the error is not cleared.

To Reproduce Go to https://observablehq.com/@tomlarkworthy/bug-unresolved-error-cells use toggle, note the last cell does not have its error markings removed

image
tomlarkworthy commented 2 years ago

OH and just noticed in the repro that the error containing cell doesn't clear it's error either.

mootari commented 2 years ago

In essence, the editor error won't clear until the cell resolves. Shorter repro:

  1. Create a new JS cell
  2. Type Promises.delay(1000 and submit, which will report a syntax error
  3. Type ) and submit, fixing the error. The error will only clear after a 1 second delay.