observablehq / feedback

Customer submitted bugs and feature requests
42 stars 3 forks source link

Table data cell SQL should escape columns #452

Closed domoritz closed 2 years ago

domoritz commented 2 years ago

In https://observablehq.com/d/4eae70d9aa34c86d, the table data cell doesn't escape a column with a - in it so the SQL query is invalid.

Screenshot 2022-06-22 at 7 52 55 PM
mbostock commented 2 years ago

It looks like the DuckDBClient doesn’t implement escape:

https://observablehq.com/@observablehq/database-client-specification#§4.3

If you implement that, it should work. If it doesn’t, it is a bug on our end. Let us know!

domoritz commented 2 years ago

I missed that. Implemented and now it works as expected. Thank you!

Screenshot 2022-06-22 at 9 51 38 PM