observablehq / feedback

Customer submitted bugs and feature requests
42 stars 3 forks source link

got a bit confused with the sharing modals (and defaults) #638

Open aaronkyle opened 2 weeks ago

aaronkyle commented 2 weeks ago

Describe the bug Perhaps the bug is how I interpreted the default behavior for the sharing modal. It works. I read the default gray in the team access section to indicate that members of the team were not shared a notebook when in fact they were.

With respect to the functionality of the sharing modal for Framework projects, I find the defaults a bit troubling in that a 'private' project is by default shared to the entire team, and to 'unshare' it I must know to add an editor, then to revoke team access. I would prefer an approach that gradually allows me to add in permissions for broader visibility within a team, rather than having to start of by taking steps to restrict.

To Reproduce Steps to reproduce the behavior:

  1. Create a framework project and deploy it privately:

    Screenshot 2024-06-14 at 8 25 28 AM
  2. Go to the team space and check the sharing settings. Note that the project is externally restricted. Also note that the sharing modal for team users is greyed out:

    Screenshot 2024-06-14 at 8 26 28 AM

It's exactly this greyed out setting that led me to believe that my team was not shared on a notebook.

When I added myself as an editor, I initially didn't notice that the team permissions toggle became active, and didn't quite put it together that all members would have access. Being focused on the 'add user' action, I assumed I had to add in all the editors I wanted.

Expected behavior

I would expect that a notebook that starts as 'private' would be 'private to me' and that I would add in people or groups later.

dunstan commented 2 weeks ago

Thanks for bringing this up, Aaron. You're absolutely right. We have two ways to improve this, and I thought we had open issues for both of them, but on checking I see one of them hadn't been documented, so I've done that now. Not sure when we'll get the improvements out, but at least we have them in the system now.