observablehq / framework

A static site generator for data apps, dashboards, reports, and more. Observable Framework combines JavaScript on the front-end for interactive graphics with any language on the back-end for data analysis.
https://observablehq.com/framework/
ISC License
2.41k stars 111 forks source link

no poll delay for deploy tests #1399

Closed mbostock closed 4 months ago

mbostock commented 4 months ago

The deployPollInterval was set to zero, but the deploy command wasn’t respecting this due to a logical error (||). Also, the deployPollInterval needs to be passed through to the loginInner method’s pollTime option to avoid polling there, too. If desired, we could make this latter polling interval a separate option for the deploy command, but it seems reasonable to have the same option apply to both. (And maybe in the future we could avoid polling entirely with server-sent events or some such?)

On my computer, this makes the tests take 4.9 seconds, down from 15.5 seconds.